[PATCH] D159098: [NFC][AMDGPU] Small cleanup to R600 CF Finalizer

Thu Aug 31 16:06:45 PDT 2023

arsenm added a comment.

In D159098#4628449 <https://reviews.llvm.org/D159098#4628449>, @ldrumm wrote:

> `DstMI` is set to zero which is apparently an invalid `Register`

Correct

> `TRI->getMatchingSuperReg(t0_xy, 1, R600_Reg128RegClass)` is the culprit returning zero. Is that expected? I see t0_Xy is part of the R600_Reg64 class, but not part of the 128bit register class.

getMatchingSuperReg should use a subreg index, not a 1? Assuming 1=sub0, Using a 32-bit subregister here with a 64-bit class doesn't make sense to me. It would need to use sub0_sub1. I don't know what getMatchingSuperReg is supposed to do in that case

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159098/new/

https://reviews.llvm.org/D159098