[PATCH] D156767: [AArch64] [BranchRelaxation] Optimize for hot code size in AArch64 branch relaxation

[Mingming Liu via Phabricator via llvm-commits]

mingmingl added a comment.

thanks! The implementation makes sense to me. I'm not very familiar with this pass though, so maybe we could wait a little bit more for owners.



================
Comment at: llvm/lib/CodeGen/BranchRelaxation.cpp:595
 
   // If RestoreBB is required, try to place just before DestBB.
   if (!RestoreBB->empty()) {
----------------
nit: move this after the cold->hot handling ( `if (MBB->getSectionID() == MBBSectionID::ColdSectionID && DestBB->getSectionID() != MBBSectionID::ColdSectionID)`), or maybe update it accordingly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156767/new/

https://reviews.llvm.org/D156767