[PATCH] D159282: [AArch64] Ensure we do not access illegal operands in tryCombineMULLWithUZP1

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 31 14:32:50 PDT 2023


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:22984
     SDNode *ExtractLowUser = *ExtractLow.getNode()->use_begin();
     if (ExtractLowUser->getOpcode() != N->getOpcode())
       HasFoundMULLow = false;
----------------
Minor nit: add braces around "if" body so it more obviously matches the "else".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159282/new/

https://reviews.llvm.org/D159282



More information about the llvm-commits mailing list