[PATCH] D158062: [RISCV] Teach RISCVMergeBaseOffset to handle inline asm

Thu Aug 31 14:10:23 PDT 2023

nickdesaulniers added a comment.

Sorry for the revert, but I've left two reduced test cases in https://github.com/ClangBuiltLinux/linux/issues/1928. My hope is that those can help you reland this work.

In D158062#4632485 <https://reviews.llvm.org/D158062#4632485>, @jrtc27 wrote:

> Doing it for m is fine. What's not fine is doing it for A, as used by Linux in the reported errors, which presumably presents itself close enough to m to not be caught by the code here. Presumably we need a constraint_A_with_global_1 test to catch this.

Ah, good eye! That appeared in both reproducers linked above.  Thanks for taking the time to analyze this and for your quick feedback @jrtc27 and @craig.topper .

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158062/new/

https://reviews.llvm.org/D158062