[PATCH] D159162: [llvm] Add assembly syntax highlighting

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added inline comments.


================
Comment at: llvm/include/llvm/MC/MCInstPrinter.h:95
+    Target,
+    Memory,
+  };
----------------
jroelofs wrote:
> Coloring the comments too would be nice.
Agreed. Time permitting I might add that in a follow-up. 


================
Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp:282
+      O << "#";
+      MI->getOperand(1).getExpr()->print(O, &MAI);
+    }
----------------
jroelofs wrote:
> stray tab?
Yeah huh not sure how that snuck in there. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159162/new/

https://reviews.llvm.org/D159162