[PATCH] D153258: AMDGPU: Optimize set_rounding if input is known to fit in 2 bits
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 31 12:05:22 PDT 2023
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:3628-3629
- SDValue TableValue =
- DAG.getNode(ISD::SRL, SL, MVT::i64, BitTable, RoundModeTimesNumBits);
- SDValue TruncTable = DAG.getNode(ISD::TRUNCATE, SL, MVT::i32, TableValue);
+ // TODO: SimplifyDemandedBits on the setreg source here can likely reduce
+ // the table extracted bits into inline immediates.
+ } else {
----------------
Pierre-vh wrote:
> Does that take a lot of effort to add? Why not add it now?
There are enough cases to think about in one patch as it is
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153258/new/
https://reviews.llvm.org/D153258
More information about the llvm-commits
mailing list