[PATCH] D159303: [AMDGPU] Precommit test for i8 vector CopyToReg handling patch

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

function-args.ll and call-argument-types.ll seem to be missing all the i8 vectors



================
Comment at: llvm/test/CodeGen/AMDGPU/vni8-across-blocks.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 2
+; RUN: llc -march=amdgcn -mcpu=gfx906 -verify-machineinstrs < %s | FileCheck --check-prefix=GFX906 %s
+
----------------
don't need -verify-machineinstrs


================
Comment at: llvm/test/CodeGen/AMDGPU/vni8-across-blocks.ll:4
+
+define amdgpu_kernel void @v4i8_liveout(ptr addrspace(1) %src1,
+; GFX906-LABEL: v4i8_liveout:
----------------
add a v3 and v5 version


================
Comment at: llvm/test/CodeGen/AMDGPU/vni8-across-blocks.ll:45-46
+; GFX906-NEXT:    s_endpgm
+                                       ptr addrspace(1) %src2,
+                                       ptr addrspace(1) nocapture %dst) {
+entry:
----------------
update_llc_test_checks is too dumb to deal with split argument lists across lines, can you move these


================
Comment at: llvm/test/CodeGen/AMDGPU/vni8-across-blocks.ll:147
+}
+
+declare i32 @llvm.amdgcn.workitem.id.x()
----------------
v16/v32?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159303/new/

https://reviews.llvm.org/D159303