[PATCH] D158864: [Code Coverage] Add a script to check code coverage of a patch

Shivam Gupta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 31 10:54:20 PDT 2023


xgupta marked 2 inline comments as done.
xgupta added inline comments.


================
Comment at: llvm/utils/git-check-coverage:121-134
+        cmake_command = [
+            "cmake",
+            "-G",
+            "Ninja",
+            llvm_source_dir,
+            "-DCMAKE_BUILD_TYPE=Release",
+            "-DLLVM_ENABLE_ASSERTIONS=ON",
----------------
hnrklssn wrote:
> We should only add the flags we need to an existing cmake config
Handles by the second patch of this patch series, marking as done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158864/new/

https://reviews.llvm.org/D158864



More information about the llvm-commits mailing list