[PATCH] D159162: [llvm] Add assembly syntax highlighting

[Jon Roelofs via Phabricator via llvm-commits]

jroelofs added a comment.

love it!



================
Comment at: llvm/include/llvm/MC/MCInstPrinter.h:100
+  public:
+    WithMarkup(raw_ostream &OS, Markup M, bool EnableMarkup, bool EnableColor);
+    ~WithMarkup();
----------------
maybe this should be `[[nodiscard]]`


================
Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp:282
+      O << "#";
+      MI->getOperand(1).getExpr()->print(O, &MAI);
+    }
----------------
stray tab?


================
Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp:295
+      O << "#";
+      MI->getOperand(2).getExpr()->print(O, &MAI);
+    }
----------------
likewise


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159162/new/

https://reviews.llvm.org/D159162