[PATCH] D156129: Attributor: Try to propagate concrete denormal-fp-math{-f32}

[Sameer Sahasrabuddhe via Phabricator via llvm-commits]

sameerds accepted this revision.
sameerds added a comment.
This revision is now accepted and ready to land.

LGTM, with a few nits.



================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:5114-5116
+    bool operator!=(const DenormalState Other) const {
+      return Mode != Other.Mode || ModeF32 != Other.ModeF32;
+    }
----------------
The usual way is to just invert the `==` operator?


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:6317-6320
   /// This function should return true if the type of the \p AA is
   /// AAIndirectCallInfo
+  /// This function should return true if the type of the \p AA is
+  /// AADenormalFPMath.
----------------
Is this just a quirk of how Phab displays the diff? Or the new struct started at the wrong point?


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:8988
+
+    // TODO: Handling this here prevents handling the case where a caller has a
+    // fixed denormal-fp-math with dynamic denormal-fp-math-f32, but called from
----------------
Did you mean "callee"?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156129/new/

https://reviews.llvm.org/D156129