[PATCH] D154984: [lit] Drop "Script:", make -v and -a imply -vv

[Mikael Holmén via Phabricator via llvm-commits]

uabelho added a comment.

In D154984#4628289 <https://reviews.llvm.org/D154984#4628289>, @awarzynski wrote:

>> I'm not sure if this has been discussed already
>
> Yes, it has. That was my original feedback for this change and in reply Joel has done 2 very helpful things:
>
> - implemented https://reviews.llvm.org/D156954 as a "workaround" that I personally find very satisfactory,
> - posted an RFC to discourse to raise awareness of these changes: https://discourse.llvm.org/t/rfc-improving-lits-debug-output/.
>
> Please be mindful that this change (as well as other LIT patches that are being worked on in tandem) bring various improvements to the overall LIT infrastructure. These things often require compromises. In the case of `-a` flag (and the "Script" block being removed), it means having to use LIT's internal shell. That was mentioned:
>
> - as a caveat <https://discourse.llvm.org/t/rfc-improving-lits-debug-output/72839#caveat-4> on Discourse in the original RFC,
> - in this very helpful and informative reply on Discourse <https://discourse.llvm.org/t/rfc-improving-lits-debug-output/72839/3>.
>
> Tl;Dr Please try and see whether that is sufficient for you:
>
>   LIT_USE_INTERNAL_SHELL=1 path/to/llvm-lit ... 
>
> If not then I suggest taking this discussion back to Discourse. For better visibility.

Thanks! I had no idea about this lit internal shell thing.
So, using

> LIT_USE_INTERNAL_SHELL=1 path/to/llvm-lit ...

makes it look nice. Thanks for pointing this out!

Next question then would be why isn't LIT_USE_INTERNAL_SHELL=1 the default. But yeah I saw from the RFC thread not all tests work with that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154984/new/

https://reviews.llvm.org/D154984