[PATCH] D159215: [RISCV] Fix crash during during i1 vector bitreverse lowering

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 30 22:35:21 PDT 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:4230
   unsigned ViaEltSize = std::max((uint64_t)8, PowerOf2Ceil(NumElts));
   MVT ViaVT = MVT::getVectorVT(MVT::getIntegerVT(ViaEltSize), 1);
+  if (!ViaVT.isValid())
----------------
Can we use `EVT ViaVT = EVT::getVectorVT(*DAG.getContext(), EVT::getIntegerVT(*DAG.getContext(), ViaEltSize), 1);` so we're not trying to create non-existent MVTs?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159215/new/

https://reviews.llvm.org/D159215



More information about the llvm-commits mailing list