[PATCH] D159165: [NFC][HWASAN] Extract insertShadowTagCheck()

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 30 21:25:37 PDT 2023


vitalybuka added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:918
+  ShadowTagCheckInfo TagCheck = insertShadowTagCheck(Ptr, InsertBefore);
+  Instruction *CheckTerm = TagCheck.MismatchTerm;
 
----------------
fmayer wrote:
> I would either call both of them `CheckTerm`, or both of them `MismatchTerm`
I'll rename in a separate patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159165/new/

https://reviews.llvm.org/D159165



More information about the llvm-commits mailing list