[PATCH] D159172: [HWASAN] Inline fast pass of instrumentMemAccessOutline

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:898-899
   if (InlineFastPath) {
-    // TODO.
+    // TODO: Now we can pass a tag just loaded from the shadow into an
+    // intrinsic.
+    InsertBefore = insertShadowTagCheck(Ptr, InsertBefore).MismatchTerm;
----------------
fmayer wrote:
> This comment is a bit confusing. Maybe "TODO: use the tag we loaded  for the check below"?
That not what I meant to say, but I guess I will just remove TODO
I am not very positive that we will proceed on that one anyway


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159172/new/

https://reviews.llvm.org/D159172