[PATCH] D66786: [x86] Fix bugs of some intrinsic functions in CLANG : _mm512_stream_ps, _mm512_stream_pd, _mm512_stream_si512

Freddy, Ye via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 30 21:00:25 PDT 2023


FreddyYe added a comment.

In D66786#4628233 <https://reviews.llvm.org/D66786#4628233>, @RKSimon wrote:

> In D66786#4627385 <https://reviews.llvm.org/D66786#4627385>, @FreddyYe wrote:
>
>> In D66786#1654183 <https://reviews.llvm.org/D66786#1654183>, @craig.topper wrote:
>>
>>> I think @rksimon was asking to have tests with the original type and with the new void type. Just to verify that we accept code we used to accept and that we now accept void.
>>
>> Sorry for ping this long long ago Phab... I just found we are missing alignment between these intrinsics' 512 variants and 128/256 ones. Does anyone remember the motivation here? The intrinsic guide also suffers such unaligning issue, but we can refine there, too if we could have a conclusion here. BTW gcc doesn't have such fix so they used aligned type* for these intrinsics.
>
> The tests (and the doxygen descriptions for sse2/avxavx2 headers) all have vector-alignment requirements - where did you find it missing?

The issue is 128/256 variants both used type* but 512 variants here used void*.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66786/new/

https://reviews.llvm.org/D66786



More information about the llvm-commits mailing list