[PATCH] D158328: [PowerPC] Merge rotate and clear into single instruction.

[Lei Huang via Phabricator via llvm-commits]

lei added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:5097
+  SDValue Val = N->getOperand(0);
+  SDLoc dl(N);
+
----------------
nit: maybe move `MB` and `dl` def down to right before it's used on line 5106?


================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:5631-5632
+    if (tryAsSingleRLWINM(N) || tryAsSingleRLWIMI(N) || tryAsSingleRLDCL(N) ||
+	tryAsSingleRLDICL(N) || tryAsSingleRLDICR(N) || tryAsSingleRLWINM8(N) ||
+	tryAsPairOfRLDICL(N))
       return;
----------------
nit: indentation 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158328/new/

https://reviews.llvm.org/D158328