[PATCH] D158614: [UBSan] Disable the function sanitizer on an execute-only target.
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 30 20:14:44 PDT 2023
MaskRay added inline comments.
================
Comment at: clang/lib/Basic/Sanitizers.cpp:130
+ if (A->getOption().matches(clang::driver::options::OPT_mexecute_only) &&
+ llvm::ARM::supportedExecuteOnly(Triple)) {
+ return true;
----------------
MaskRay wrote:
> I don't think we need an extra `llvm::ARM::supportedExecuteOnly` check. We just return true when `-mexecute-only` is in effect.
Sorry, I just noticed that this adds a circular (if we consider headers) dependency from clangBasic to clangDriver. I'm removing it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158614/new/
https://reviews.llvm.org/D158614
More information about the llvm-commits
mailing list