[PATCH] D158889: [AsmPrinter][PGO] Adds optional dumping of branch probabilities for PGO metrics.

[Micah Weston via Phabricator via llvm-commits]

red1bluelost marked 2 inline comments as done.
red1bluelost added inline comments.


================
Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:1225
+  unsigned Flags = ELF::SHF_LINK_ORDER;
+  StringRef GroupName;
+  if (const MCSymbol *Group = ElfSec.getGroup()) {
----------------
MaskRay wrote:
> This logic hasn't been thoroughly tested. We need comdat and `!associated`. Please see the log of the code you copied from.
Could you elaborate on this? I'm very confused as to what you are referring to or how to go about fixing it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158889/new/

https://reviews.llvm.org/D158889