[PATCH] D158889: [AsmPrinter][PGO] Adds optional dumping of branch probabilities for PGO metrics.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay requested changes to this revision.
MaskRay added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/test/Transforms/PGOProfile/asm_emit_branch_prob.ll:1
+; REQUIRES: x86_64-linux
+
----------------
We likely need an explicit `-mtriple=x86_64` for llc commands and use `REQUIRES: x86-registered-target`.


================
Comment at: llvm/test/Transforms/PGOProfile/asm_emit_branch_prob.ll:68
+
+; CHECK-NO-BP-SEC:llvm-readelf: warning: '{{.*}}': could not find section '.branch_probabilities'
----------------
Please don't test the string before `warning:`. It's not reliable in some environments when the tool is a symlink to a real executable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158889/new/

https://reviews.llvm.org/D158889