[PATCH] D157322: [VPlan] Initial modeling of runtime VF * UF as VPValue.

[Kolya Panchenko via Phabricator via llvm-commits]

nikolaypanchenko added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:2469
 
+  /// Represents the runtime VF * UF of the vector loop region.
+  VPValue RuntimeVFxUF;
----------------
fhahn wrote:
> nikolaypanchenko wrote:
> > might be better to clarify that it's loop invariant VPValue.
> > With @ABataev patch in, we may followup to unify `EVL` and `RuntimeVFxUF`. Does it sound reasonable ? 
> > might be better to clarify that it's loop invariant VPValue.
> 
> Updated, thanks!
> 
> > With @ABataev patch in, we may followup to unify EVL and RuntimeVFxUF. Does it sound reasonable ?
> 
> 
> Sounds good. I think another suggestion/option that @Ayal had was to keep the canonical induction increment fixed (incrementing by a variable value would make it non-canonical) to control the loop and use EVL to only control the lanes accessed by (vector) recipes.
Can you please elaborate needs of having canonical loop form out of the vectorizer ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157322/new/

https://reviews.llvm.org/D157322