[PATCH] D158689: [llvm-profdata] Use llvm::DenseMap in SampleProfileMap

William Junda Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 30 13:05:52 PDT 2023

huangjd added a comment.

In D158689#4629032 <https://reviews.llvm.org/D158689#4629032>, @davidxl wrote:

> Interesting. @williamjhuang can you double check your measurement ? If the improvement can be reproduced, do some profiling and understand where the performance come from is useful.

I measured the time on reading the function offset table section and reading the entire profile, not the compilation time. The other steps in the compilation pipeline are expected to take up a much longer time than reading the profile (actually only the function table is always being read, the samples are read only if they match some functions in the source code), so we need to have a common ground on what's being measured.

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list