[PATCH] D157030: InstCombine: Fold out scale-if-denormal pattern

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 30 12:08:50 PDT 2023


goldstein.w.n accepted this revision.
goldstein.w.n added a comment.
This revision is now accepted and ready to land.

Okay, LGTM.

FP stuff is not an area I'm really qualified to review so it would be nice if a second opinion
also chimed in, but if no one else is up to review think its okay to push.
Please way a few days to push to give other times to review.



================
Comment at: llvm/test/Transforms/InstCombine/fold-select-fmul-if-zero.ll:398
   ret float %scaled.if.denormal
 }
 
----------------
arsenm wrote:
> goldstein.w.n wrote:
> > Why does this fail?
> The nsz needs to be set on the select. nsz on the fmul is insufficient
Ah yeah that makes sense.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157030/new/

https://reviews.llvm.org/D157030



More information about the llvm-commits mailing list