[PATCH] D158915: [InstCombine] optimized implementations of min/max for bool
Noah Goldstein via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 30 11:52:22 PDT 2023
goldstein.w.n added inline comments.
================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:1630
+ return BinaryOperator::CreateOr(I0, I1);
+ }
+
----------------
If you remove the bracket, can you move the comments to before the `if`. Non-bracket if with multiline comments before statement are a bit error-prone imo.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158915/new/
https://reviews.llvm.org/D158915
More information about the llvm-commits
mailing list