[PATCH] D157484: [VPlan] Support scalable vectors in outer-loop vectorization

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 30 08:34:57 PDT 2023


fhahn added a comment.

Looks reasonable overall, my only concern is that this adds another codepath to the native path which is already lacking test coverage in general. Do you have any idea/suggestion on how to improve end-to-end test coverage, e.g. in `llvm-test-suite` (could be adding some `SingleSource` tests with loop nests and ` #pragma clang loop vectorize_width(4)`?



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:7384
+                        << "not supported by the target.\n");
+      reportVectorizationFailure(
+          "Scalable vectorization requested but not supported by the target",
----------------
Can a test be added for this case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157484/new/

https://reviews.llvm.org/D157484



More information about the llvm-commits mailing list