[PATCH] D158915: [InstCombine] optimized implementations of min/max for bool

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:1619
+    if ((IID == Intrinsic::umin || IID == Intrinsic::smax) &&
+	    (II->getType()->isIntOrIntVectorTy(1))) {
+      // umin(i1 X, i1 Y) -> and i1 X, Y
----------------
remove superfluous brackets: `II->getType()->isIntOrIntVectorTy(1)`


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:1626
+    if ((IID == Intrinsic::umax || IID == Intrinsic::smin) &&
+	    (II->getType()->isIntOrIntVectorTy(1))) {
+      // umax(i1 X, i1 Y) -> or i1 X, Y
----------------
remove superfluous brackets: II->getType()->isIntOrIntVectorTy(1)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158915/new/

https://reviews.llvm.org/D158915