[PATCH] D154157: [LV] Cost model for out-of-loop reductions

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 30 07:52:39 PDT 2023


fhahn added a comment.

In D154157#4628496 <https://reviews.llvm.org/D154157#4628496>, @anna wrote:

> Gentle ping @fhahn. Anything I could do to move this forward? I have kept the option as off by default, since I would need to help to test this on supported targets upstream. It helps our use-case where loops are not vectorized when out-of-loop reductions are present in small trip count loops. 
> There maybe some fallouts where correction in reductions cost modelling will be required.

What are the regressions on ARM/RISCV? I think we should aim to enable this by default for all platforms, otherwise it is at the risk of not getting enabled. Also, those tests may show issues with the current implementation.

Do you have any numbers on the impact on X86?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154157/new/

https://reviews.llvm.org/D154157



More information about the llvm-commits mailing list