[PATCH] D159207: Bug fix for D154102, where multi-line labels would get incorrect header splitter line in CFG dot

Marek Sedláček via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 30 07:48:47 PDT 2023


mark-sed created this revision.
mark-sed added reviewers: apilipenko, cdevadas, rcorcs.
Herald added subscribers: kerbowa, jvesely.
Herald added a project: All.
mark-sed requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Currently when control flow dot graph is generated for a function with basic block name longer than 80 lines, then the header separator will be placed after the line break for the label name instead of after the whole label name. The fix is simple by just moving the insert of | character before the line splitting happens.

A test for this was also added.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D159207

Files:
  llvm/include/llvm/Analysis/CFGPrinter.h
  llvm/test/Analysis/DotMachineCFG/AMDGPU/functions.mir
  llvm/test/Analysis/DotMachineCFG/AMDGPU/irreducible.mir
  llvm/test/Other/cfg-multiline-header.ll
  llvm/test/Other/cfg_deopt_unreach.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D159207.554721.patch
Type: text/x-patch
Size: 9837 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230830/50fc2461/attachment.bin>


More information about the llvm-commits mailing list