[PATCH] D159193: [AArch64][SME] Disable remat of VL-dependent ops when function changes streaming mode.

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 30 07:40:11 PDT 2023


aemerson accepted this revision.
aemerson added a comment.
This revision is now accepted and ready to land.

I have a slight concern that relying on the MFI's flag being set on a DAG codegen call is brittle, in case in future there are other pathways that change streaming mode. Scanning the function seems a more reliable way to set the flag, but for now this is ok with me.



================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:8540
+                   AArch64::PPRRegClass.hasSubClassEq(RC);
+          assert(!MO.getReg().isVirtual() && "Expected a phsyical register");
+          return AArch64::ZPRRegClass.contains(MO.getReg()) ||
----------------
physical


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159193/new/

https://reviews.llvm.org/D159193



More information about the llvm-commits mailing list