[PATCH] D159186: [AArch64][SME] Enable TPIDR2 lazy-save for za_preserved

Matt Devereau via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 30 07:26:47 PDT 2023


MattDevereau added inline comments.


================
Comment at: llvm/lib/Target/AArch64/Utils/AArch64SMEAttributes.h:79
   bool hasPrivateZAInterface() const { return !hasSharedZAInterface(); }
-  bool preservesZA() const { return Bitmask & ZA_Preserved; }
+  bool hasPreservedZAInterface() const { return Bitmask & ZA_Preserved; }
   bool hasZAState() const {
----------------
sdesmalen wrote:
> Could you keep the original name please?
Can I do it as a separate change at least? It doesn't match the rest of the class's interface at all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159186/new/

https://reviews.llvm.org/D159186



More information about the llvm-commits mailing list