[PATCH] D154984: [lit] Drop "Script:", make -v and -a imply -vv
Andrzej Warzynski via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 30 06:59:33 PDT 2023
awarzynski added a comment.
> I'm not sure if this has been discussed already
Yes, it has. That was my original feedback for this change and in reply Joel has done 2 very helpful things:
- implemented https://reviews.llvm.org/D156954 as a "workaround" that I personally find very satisfactory,
- posted an RFC to discourse to raise awareness of these changes: https://discourse.llvm.org/t/rfc-improving-lits-debug-output/.
Please be mindful that this change (as well as other LIT patches that are being worked on in tandem) bring various improvements to the overall LIT infrastructure. These things often require compromises. In the case of `-a` flag (and the "Script" block being removed), it means having to use LIT's internal shell. That was mentioned:
- as a caveat <https://discourse.llvm.org/t/rfc-improving-lits-debug-output/72839#caveat-4> on Discourse in the original RFC,
- in this very helpful and informative reply on Discourse <https://discourse.llvm.org/t/rfc-improving-lits-debug-output/72839/3>.
Tl;Dr Please try and see whether that is sufficient for you:
LIT_USE_INTERNAL_SHELL=1 path/to/llvm-lit ...
If not then I suggest taking this discussion back to Discourse. For better visibility.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154984/new/
https://reviews.llvm.org/D154984
More information about the llvm-commits
mailing list