[PATCH] D159052: [PowerPC] fix the PowerPC cases, NFC
Qiu Chaofan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 30 02:31:52 PDT 2023
qiucf added a comment.
`SMALL-ASM`, `LARGE-ASM` and `FUNC-ASM` has conflicting outputs so the script cannot handle:
# FUNC-ASM
# 32-bit
lwz 4, L..C0(2) # %jump-table.0
slwi 3, 3, 2
lwzx 3, 3, 4
# 64-bit
ld 4, L..C0(2) # %jump-table.0
rldic 3, 3, 2, 30
lwax 3, 3, 4
Besides, update llc script uses `r'^[_.]?(?P=func):(?:[ \t]*#+[ \t]*@"?(?P=func)"?)?\n'` regex to match `func:` label in PPC asm, while the `jump_table` function here does not have such label. I doubt whether removing this check would cause regression in other cases. So I'd prefer keep cases here as manual.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159052/new/
https://reviews.llvm.org/D159052
More information about the llvm-commits
mailing list