[PATCH] D154984: [lit] Drop "Script:", make -v and -a imply -vv

[Mikael Holmén via Phabricator via llvm-commits]

uabelho added a comment.

Hi,

I'm not sure if this has been discussed already but I just noticed a change with this patch that at least makes it a bit annoying.
So before running

  build-all//bin/llvm-lit -a test/Transforms/ArgumentPromotion/opaque-ptr.ll

yielded

  : 'RUN: at line 2';   /repo/uabelho/dev-main/llvm/build-all/bin/opt -S -passes=argpromotion < /repo/uabelho/dev-main/llvm/test/Transforms/ArgumentPromotion/opaque-ptr.ll | /repo/uabelho/dev-main/llvm/build-all/bin/FileCheck /repo/uabelho/dev-main/llvm/test/Transforms/ArgumentPromotion/opaque-ptr.ll

which I could directly copy and paste into my terminal to reproduce the test.
Now I instead get

  + : 'RUN: at line 2'
  + /repo/uabelho/dev-main/llvm/build-all/bin/opt -S -passes=argpromotion
  + /repo/uabelho/dev-main/llvm/build-all/bin/FileCheck /repo/uabelho/dev-main/llvm/test/Transforms/ArgumentPromotion/opaque-ptr.ll

where the "opt" line doesn't even include the test file fed to opt via "< %s". Sure you see the file in the FileCheck command but before reproducing could be done with one single copy/paste, now it takes three.

This will be annoying every time a lit test fails and you want to reproduce it...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154984/new/

https://reviews.llvm.org/D154984