[PATCH] D159097: [GlobalISel] Try to commute G_CONSTANT_FOLD_BARRIER LHS operands to RHS.

Pierre van Houtryve via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 29 23:58:45 PDT 2023


Pierre-vh accepted this revision.
Pierre-vh added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:6028-6032
+  if (RHSDef->getOpcode() != TargetOpcode::G_CONSTANT_FOLD_BARRIER &&
+      !getIConstantVRegVal(RHS, MRI).has_value())
+    return true;
+
+  return false;
----------------



================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/combine-const-fold-barrier-rhs.mir:5
+name:            cfb_lhs
+alignment:       4
+tracksRegLiveness: true
----------------
is alignment necessary?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159097/new/

https://reviews.llvm.org/D159097



More information about the llvm-commits mailing list