[PATCH] D159114: [llvm-objdump][RISCV] Print target of auipc+jalr calls

[Alexander Richardson via Phabricator via llvm-commits]

arichardson added inline comments.


================
Comment at: llvm/include/llvm/MC/MCInstrAnalysis.h:173
+  /// up two instructions (e.g. auipc+jalr).
+  virtual bool evaluateBranch(const MCInst &Inst1, const MCInst &Inst2,
+                              uint64_t Addr, uint64_t &Target) const;
----------------
How about passing the optional PrevInst to to the existing evaluateBranch() instead? Having to choose which overload to implement is bit awkward and means two calls per instruction instead of just one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159114/new/

https://reviews.llvm.org/D159114