[PATCH] D159162: [llvm] Add assembly syntax highlighting

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added a comment.

In D159162#4627195 <https://reviews.llvm.org/D159162#4627195>, @MaskRay wrote:

> In 2019 there is a patch series (D65189 <https://reviews.llvm.org/D65189>/D65190 <https://reviews.llvm.org/D65190>/D65191 <https://reviews.llvm.org/D65191>). I wonder whether some parts can be reused.

I like how the first patch merges the "markup" and the "highlighting": that's something I considered myself. I'll need to take a more thorough look tomorrow to understand the purpose of the span and stack it uses. At least for the arm64 backend I don't think that's necessary as the start and end are clearly delineated.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159162/new/

https://reviews.llvm.org/D159162