[PATCH] D159148: Do not duplicate identical stack safety test for RISCV

Florian Mayer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 29 21:12:51 PDT 2023


fmayer added inline comments.


================
Comment at: llvm/test/Instrumentation/HWAddressSanitizer/stack-safety-analysis.ll:11
 
 target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128"
 
----------------
jrtc27 wrote:
> This is a bit dodgy as this isn't a data layout used by RISC-V, but hard to avoid without D141060 unless you want to duplicate the test or put the data layout as an argument to opt
For what it's worth, that is also the data layout that is used in the deleted `llvm/test/Instrumentation/HWAddressSanitizer/RISCV/stack-safety-analysis.ll`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159148/new/

https://reviews.llvm.org/D159148



More information about the llvm-commits mailing list