[PATCH] D158317: [IR] Add SturcturalHash printer pass

[Aiden Grossman via Phabricator via llvm-commits]

aidengrossman marked an inline comment as done.
aidengrossman added inline comments.


================
Comment at: llvm/test/Analysis/StructuralHash/structural-hash-detailed.ll:11
+
+; CHECK: Module Hash: 81f1328ced269bd
+; CHECK: Function f1 Hash: 81f1328ced269bd
----------------
aeubanks wrote:
> aeubanks wrote:
> > add a comment about expecting the number to be stable across runs
> actually I just had the idea that you can run it twice and diff the outputs to make sure they're the same, that's way more resistant to random changes
That's definitely a better way of doing it. Thanks for the suggestion! I'll push a commit up with that change. It won't show up locally on some of the machines I work on because they have ASLR disabled, but all (or at least most) of the buildbots should have that enabled which is what matters more for coverage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158317/new/

https://reviews.llvm.org/D158317