[PATCH] D153587: [GlobPattern] Support brace expansions

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: llvm/include/llvm/Support/GlobPattern.h:84
+    SmallVector<Bracket, 0> Brackets;
+    std::string Pat;
+  };
----------------
ellis wrote:
> MaskRay wrote:
> > Perhaps `SmallVector<, 0>` to save memory. For the cases we care about performance, the pattern is typically longer than the max inlined element size in libc++/libstdc++ (15 or 23).
> I'm curious, why not leave out the `0` and just have `SmallVector<char> Pat`?
I consider it unfortunate... Omitting the argument has been reserved to select an inline size to have about 64 bytes IIUC.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153587/new/

https://reviews.llvm.org/D153587