[PATCH] D156725: [CSSPGO] Skip reporting staleness metrics for imported functions

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:2425
     if (const auto *FS = Reader.getSamplesFor(F))
       countProfileMismatches(F, *FS, IRAnchors, ProfileAnchors);
   }
----------------
As discussed in the other patch `https://reviews.llvm.org/D158891`, skipping external functions may cause its nested non-external callee samples to be skipped too. This is not what we want?


================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:2453
+    FunctionSamples *FS = Reader.getSamplesFor(F);
+    ;
+    FunctionSamples *FSForMatching = FS;
----------------
nit: remove the colon


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156725/new/

https://reviews.llvm.org/D156725