[PATCH] D158891: [CSSPGO] Retire FlattenProfileForMatching
Hongtao Yu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 29 16:44:51 PDT 2023
hoy added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:2402
+ // Use top-level nested FS for counting profile mismatch metrics since
+ // currently once a callsite is mismatched, all its children profile are
+ // dropped.
----------------
nit: profile -> profiles
> once a callsite is mismatched, all its children profile are drooped
Why children profiles can be dropped? Counting happens before inlining right?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158891/new/
https://reviews.llvm.org/D158891
More information about the llvm-commits
mailing list