[PATCH] D159002: Attributor: Fix not propagating nofpclass arguments through transitive callers

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 29 16:41:10 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:10379
     State.addKnownBits(~KnownFPClass.KnownFPClasses);
-
-    bool TrackUse = false;
-    return TrackUse;
+    return true;
   }
----------------
jdoerfert wrote:
> Do we really follow any use?
The only uses I could think of being worth skipping would be stores or void calls, which would naturally have no uses.

Maybe unrecognizable generic calls? Filtering out those is more effort if you want to consider libcalls


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159002/new/

https://reviews.llvm.org/D159002



More information about the llvm-commits mailing list