[PATCH] D159131: [RISCV][GlobalISel] Select G_ICMP

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVGISel.td:72
+def : Pat<(XLenVT (seteq (XLenVT GPR:$rs1), simm12_plus1:$imm12)),
+          (SLTIU (ADDI GPR:$rs1, (NegImm simm12_plus1:$imm12)), 1)>;
+def : Pat<(XLenVT (setne (XLenVT GPR:$rs1), 0)), (SLTU (XLenVT X0), GPR:$rs1)>;
----------------
This pattern isn't working


================
Comment at: llvm/lib/Target/RISCV/RISCVGISel.td:77
+def : Pat<(XLenVT (setne (XLenVT GPR:$rs1), simm12_plus1:$imm12)),
+          (SLTU (XLenVT X0), (ADDI GPR:$rs1, (NegImm simm12_plus1:$imm12)))>;
+def : Pat<(XLenVT (setugt (XLenVT GPR:$rs1), GPR:$rs2)),
----------------
This pattern isn't working


================
Comment at: llvm/lib/Target/RISCV/RISCVGISel.td:91
+def : Pat<(XLenVT (setgt (XLenVT GPR:$rs1), simm12_minus1_nonzero:$imm)),
+          (XORI (SLTI GPR:$rs1, (ImmPlus1 simm12_minus1_nonzero:$imm)), 1)>;
+def : Pat<(XLenVT (setugt (XLenVT GPR:$rs1), simm12_minus1_nonzero:$imm)),
----------------
This pattern isn't working


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159131/new/

https://reviews.llvm.org/D159131