[PATCH] D159053: [RISCV] Support select/merge like ops for fp16 vectors when only have Zvfhmin

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 29 15:21:57 PDT 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:5509
+      // Skip constant.
+      if (auto Const = dyn_cast<ConstantSDNode>(Scalar))
+        break;
----------------
This seems like it might be a RISC-V specific issue and not something we should do in target specific code.

What code is reversing the promotion? That code should be checking isOperationLegal


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159053/new/

https://reviews.llvm.org/D159053



More information about the llvm-commits mailing list