[PATCH] D159111: [TableGen][GlobalISel] Add support for matching/writing MIFlags in MIR Patterns

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/docs/GlobalISel/MIRPatterns.rst:170
+Note that flags are uniqued for the whole pattern, so even if a given flag is
+mentionned multiple times, it's only checked/added once.
 
----------------



================
Comment at: llvm/docs/GlobalISel/MIRPatterns.rst:171
+mentionned multiple times, it's only checked/added once.
 
 Limitations
----------------
Should mention the default behavior. Flags should be dropped unless explicitly preserved. Can you and/or the incoming flags?


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/GIMatchTableExecutor.h:566
 protected:
-  GIMatchTableExecutor();
+  const bool PropagateMIFlags;
+
----------------
Don't see why this needs to be configurable


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159111/new/

https://reviews.llvm.org/D159111