[PATCH] D158854: [RISCV] Move vmv_s_x and vfmv_s_f special casing to DAG combine

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 29 14:42:23 PDT 2023


craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.

LGTM with that comment addressed



================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:13947
+    if (ConstantSDNode *Const = dyn_cast<ConstantSDNode>(Scalar);
+        Const && !isNullConstant(Scalar) && isInt<5>(Const->getSExtValue()) &&
+        VT.bitsLE(getLMUL1VT(VT)) && Passthru.isUndef())
----------------
`!isNullConstant(Scalar)` -> `!Const->isZero()`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158854/new/

https://reviews.llvm.org/D158854



More information about the llvm-commits mailing list