[PATCH] D158911: [BOLT] Support input binaries that use R_X86_GOTPC64

Rafael Auler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 29 14:11:06 PDT 2023


rafauler added inline comments.


================
Comment at: bolt/lib/Target/X86/X86MCSymbolizer.cpp:164
+  BinaryContext &BC = Function.getBinaryContext();
+  BinaryData *GOTSymBD = BC.getBinaryDataByName("_GLOBAL_OFFSET_TABLE_");
+  if (!GOTSymBD || !GOTSymBD->getAddress()) {
----------------
maksfb wrote:
> Can you encapsulate GOT `MCSymbol` lookup in a `BinaryContext` method?
Absolutely


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158911/new/

https://reviews.llvm.org/D158911



More information about the llvm-commits mailing list