[PATCH] D159132: [memprof] Canonicalize the function name prior to hashing.
Teresa Johnson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 29 13:31:26 PDT 2023
tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
lgtm with a stale comment cleanup
================
Comment at: llvm/lib/ProfileData/MemProf.cpp:84
// this time, it is the lower 64 bits of the md5 of the function
// name. Any suffix with .llvm. is trimmed since these are added by
// thinLTO global promotion. At the time the profile is consumed,
----------------
You can remove the last 2 sentences here since they are redundant with the above comment where we now will do the stripping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159132/new/
https://reviews.llvm.org/D159132
More information about the llvm-commits
mailing list