[PATCH] D159098: [NFC][AMDGPU] Small cleanup to R600 CF Finalizer

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 29 11:57:44 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/R600ControlFlowFinalizer.cpp:268
                               std::set<unsigned> &DstRegs) const {
-    unsigned DstMI, SrcMI;
-    for (MachineInstr::const_mop_iterator I = MI.operands_begin(),
-                                          E = MI.operands_end();
-         I != E; ++I) {
-      const MachineOperand &MO = *I;
+    std::optional<unsigned> DstMI, SrcMI;
+    for (const MachineOperand &MO : MI.operands()) {
----------------
Should just use Register in place of optional<unsigned>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159098/new/

https://reviews.llvm.org/D159098



More information about the llvm-commits mailing list