[PATCH] D159123: [CodeGen] Properly update insertion point of the builder

Danila Malyutin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 29 10:59:34 PDT 2023


danilaml added inline comments.


================
Comment at: llvm/lib/CodeGen/ComplexDeinterleavingPass.cpp:1955
                               {Node->Real, Node->Imag});
+      if (Builder.GetInsertPoint()->comesBefore(InsertPoint))
+        Builder.SetInsertPoint(InsertPoint);
----------------
Not sure if it's the good/proper place to fix it, but at least it ensures that callers of `replaceNode` will insert their instructions after it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159123/new/

https://reviews.llvm.org/D159123



More information about the llvm-commits mailing list