[PATCH] D152104: [LightAttributor] Run only as CGSCCPass.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a subscriber: tianshilei1992.
jdoerfert added inline comments.


================
Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:887
+  if (UseLightAttributor)
+    MainCGPipeline.addPass(LightweightAttributorCGSCCPass());
+  else
----------------
fhahn wrote:
> nikic wrote:
> > Supporting the SkipNonRecursive flag should improve compile-time a good bit. We only need to infer attributes at this pipeline position for non-trivial SCCs.
> When we use `PostOrderFunctionAttrsPass(/*SkipNonRecursive*/ true)` and `LightweightAttributorCGSCCPass` only at the other position, there's  unfortunately still a ~2% regression: https://llvm-compile-time-tracker.com/compare.php?from=3a458256ee22a0e7c31529de42fa6caa263d88fe&to=3e8ea897fa2533f52488b7ceab27f6b0d91599dc&stat=instructions%3Au
We'll add a skip non recursive option. @tianshilei1992 and I will look into potential regressions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152104/new/

https://reviews.llvm.org/D152104